| Summary: | First cut at SheriffBot | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Barth
2010-03-17 17:19:39 PDT
Created attachment 50978 [details]
Patch
Comment on attachment 50978 [details]
Patch
I think IRC connection should be explicit. It's "dangerous". It should just return None until someone has explicitly connected.
Or you coudl have an ensure_irc_connected() method, which makes it clear that it does work. "irc()" could leave me in some sort of false impression that it doesn't do any work, or certainly doesn't connect me to anything.
I think if we have some explicit connect method it should take a username/host/channel, as whoever is calling it will have that information.
I worry that the name "finalize" is overloaded. Maybe we should have some custom name. I think you mentioned "command_completed()" in person. The default implementation could pass.
Created attachment 50982 [details]
Patch
Comment on attachment 50982 [details]
Patch
OK.
Comment on attachment 50982 [details] Patch Clearing flags on attachment: 50982 Committed r56181: <http://trac.webkit.org/changeset/56181> All reviewed patches have been landed. Closing bug. |