Bug 36230

Summary: Image_diff.py for layout test is broken if no diff file specified
Product: WebKit Reporter: Victor Wang <victorw>
Component: Tools / TestsAssignee: Victor Wang <victorw>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dpranke, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed patch dglazkov: review+

Victor Wang
Reported 2010-03-17 11:23:44 PDT
In webkitpy/port/base.py, the syntax of command image_diff is wrong if no diff_filename specified. This breaks rebaseline tool.
Attachments
Proposed patch (1.52 KB, patch)
2010-03-17 11:36 PDT, Victor Wang 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Victor Wang
Comment 1 2010-03-17 11:36:23 PDT
Created attachment 50928 [details] Proposed patch
Dimitri Glazkov (Google)
Comment 2 2010-03-17 11:39:28 PDT
Comment on attachment 50928 [details] Proposed patch yay!
Victor Wang
Comment 3 2010-03-17 11:45:39 PDT
Committed r56123: <http://trac.webkit.org/changeset/56123>
Dirk Pranke
Comment 4 2010-03-17 14:18:00 PDT
Comment on attachment 50928 [details] Proposed patch I wonder if it would be better to split this into a different routine called compare_images() that compared them but didn't produce an actual diff, just like we have compare_text() and diff_text().
Victor Wang
Comment 5 2010-03-17 15:21:21 PDT
Sounds fine to me. (In reply to comment #4) > (From update of attachment 50928 [details]) > I wonder if it would be better to split this into a different routine called > compare_images() that compared them but didn't produce an actual diff, just > like we have compare_text() and diff_text().
Note You need to log in before you can comment on or make changes to this bug.