Bug 36204

Summary: [Chromium] Size the WebVector of forms after determining how many forms are valid and will be returned
Product: WebKit Reporter: James Hawkins <jhawkins>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, fishd, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch levin: review+

James Hawkins
Reported 2010-03-16 17:28:31 PDT
Patch will follow.
Attachments
Patch (1.31 KB, patch)
2010-03-16 18:06 PDT, James Hawkins 		no flags
DetailsFormatted DiffDiff
Patch (1.32 KB, patch)
2010-03-16 18:18 PDT, James Hawkins 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Hawkins
Comment 1 2010-03-16 18:06:07 PDT
Created attachment 50861 [details] Patch
David Levin
Comment 2 2010-03-16 18:16:51 PDT
Comment on attachment 50861 [details] Patch Pls fix the indentation to be 4 spaces on checkin.
James Hawkins
Comment 3 2010-03-16 18:18:05 PDT
Created attachment 50863 [details] Patch
Dimitri Glazkov (Google)
Comment 4 2010-03-16 18:18:33 PDT
Comment on attachment 50861 [details] Patch I am surprised style-elf didn't see it, but indents are 2, not 4. And we really need a test with this. Something simple like PASS or CRASH would do.
Dimitri Glazkov (Google)
Comment 5 2010-03-16 18:19:08 PDT
Still would like a layout test to keep this from regressing.
David Levin
Comment 6 2010-03-16 18:26:25 PDT
As discussed, please add info to the ChangeLog about why a test isn't possible.
James Hawkins
Comment 7 2010-03-16 18:54:10 PDT
Committed r56098: <http://trac.webkit.org/changeset/56098>
Note You need to log in before you can comment on or make changes to this bug.