Bug 36197

Summary: Missing support for showing layer borders and repaint count on Windows
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: WebKit Misc.Assignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch darin: review+

Enrica Casucci
Reported 2010-03-16 15:24:46 PDT
We need to add support to turn on and off the debug borders for the compositing layers on Windows.
Attachments
Patch (8.18 KB, patch)
2010-03-16 15:40 PDT, Enrica Casucci 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2010-03-16 15:40:56 PDT
Created attachment 50847 [details] Patch
WebKit Review Bot
Comment 2 2010-03-16 15:45:22 PDT
Attachment 50847 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/win/GraphicsLayerCACF.cpp:42: Alphabetical sorting problem. [build/include_order] [4] WebKit/win/WebPreferences.h:411: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2010-03-16 15:46:28 PDT
Comment on attachment 50847 [details] Patch > + cg.setFillColor(Color(0, 0, 0, 0xff), DeviceColorSpace); In a lot of other places we write this as Color::black instead. r=me
Enrica Casucci
Comment 4 2010-03-17 11:01:43 PDT
Committed revision 56118. Changed color to Color::black.
Note You need to log in before you can comment on or make changes to this bug.