Bug 36185

Summary: SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch zimmermann: review+

Description Dirk Schulze 2010-03-16 13:35:35 PDT 
SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
Comment 1 Dirk Schulze 2010-03-16 13:56:44 PDT 
Created attachment 50831 [details]
patch

patch
Comment 2 Nikolas Zimmermann 2010-03-21 11:59:55 PDT 
Comment on attachment 50831 [details]
patch

Looks great! I guess you've updated all marker test results, if that's true I'm slightly worried that we never test angle != 0.0.
Though that doesn't block the patch, so r=me. Can you have a look at non-zero marker angles and create a testcase (safe to do afterwards...)
r=me.
Comment 3 Eric Seidel (no email) 2010-03-24 14:32:39 PDT 
Attachment 50831 [details] was posted by a committer and has review+, assigning to Dirk Schulze for commit.
Comment 4 Eric Seidel (no email) 2010-03-28 09:11:17 PDT 
Broke chromium mac compile due ot warning:
cc1plus: warnings being treated as errors
In file included from /Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave/chromium-mac-release/build/WebCore/WebCore.gyp/../svg/SVGAllInOne.cpp:136:
/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave/chromium-mac-release/build/WebCore/WebCore.gyp/../svg/SVGStyledElement.cpp: In member function ‘void WebCore::SVGStyledElement::invalidateResources()’:
/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave/chromium-mac-release/build/WebCore/WebCore.gyp/../svg/SVGStyledElement.cpp:227: warning: unused variable ‘svgStyle’
Comment 5 Eric Seidel (no email) 2010-03-28 09:12:03 PDT 
Caused 3 new failures on Qt bots:
http://build.webkit.org/results/Qt%20Linux%20Release/r56693%20(9220)/results.html
Comment 6 Dirk Schulze 2010-03-28 10:03:03 PDT 
Landed in 
http://trac.webkit.org/changeset/56693

Build-fix for Chromium-Mac and DRT-Updates for Qt landed in (mixed up linux
with mac in Changelog):
http://trac.webkit.org/changeset/56694

Closing bug now.