Summary: | [EFL] Add example browser to WebKit/efl/EWebLauncher | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Leandro Pereira <leandro> | ||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Enhancement | CC: | barbieri, bunhere, commit-queue, gustavo, gyuyoung.kim, hyuki.a.kim, hyuki.kim, joone.hur, miroslaw.s, rakuco, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Leandro Pereira
2010-03-16 11:22:39 PDT
Created attachment 50813 [details]
EWebLauncher's main.c
Attachment 50813 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/efl/EWebLauncher/main.c:30: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit/efl/EWebLauncher/main.c:33: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 50813 [details]
EWebLauncher's main.c
Please also modify (in another patch) the WebKitTools/Scripts/run-launcher script to support a --efl flag for running your EFL WebLauncher.
I'm ignoring any coding style issues, as I agree with Barbieri that this should follow EFL coding style.
(In reply to comment #3) > (From update of attachment 50813 [details]) > Please also modify (in another patch) the WebKitTools/Scripts/run-launcher > script to support a --efl flag for running your EFL WebLauncher. > Done, please see bug #36181. Comment on attachment 50813 [details] EWebLauncher's main.c Clearing flags on attachment: 50813 Committed r56130: <http://trac.webkit.org/changeset/56130> All reviewed patches have been landed. Closing bug. |