Bug 36169

Summary:

CCommit queue should ignore (probably red) builders when landing rollouts

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Adam Barth 2010-03-16 09:16:43 PDT

CCommit queue should ignore (probably red) builders when landing rollouts

Comment 1 Adam Barth 2010-03-16 09:18:43 PDT

Created attachment 50800 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-03-17 12:46:55 PDT

Comment on attachment 50800 [details]
Patch

 213                 # We pass --no-update here because we've already validated

should say "in the normal case" or something instead of "here" to designate that it's the commit-queue case instead of the rollout case.

Comment 3 Adam Barth 2010-03-17 13:05:54 PDT

Created attachment 50946 [details]
Patch for landing

Comment 4 WebKit Commit Bot 2010-03-17 20:24:54 PDT

Comment on attachment 50946 [details]
Patch for landing

Clearing flags on attachment: 50946

Committed r56145: <http://trac.webkit.org/changeset/56145>

Comment 5 WebKit Commit Bot 2010-03-17 20:24:58 PDT

All reviewed patches have been landed.  Closing bug.