Bug 36155

Summary:

Let commit-queue land rollout patches even when the tree is red

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	eric: review+, eric: commit-queue-

Description Adam Barth 2010-03-15 22:39:59 PDT

Let commit-queue land rollout patches even when the tree is red

Comment 1 Adam Barth 2010-03-15 22:42:19 PDT

Created attachment 50762 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-03-15 22:49:46 PDT

Comment on attachment 50762 [details]
Patch

Use a constant:
 101         return self.name().startswith("ROLLOUT ")

This is no where near 80c:
 154         valid_patches = self.committer_validator.patches_after_rejecting_invalid_commiters_and_reviewers(all_patches)

You haz made the uglies!
186         if not patch.is_rollout() and (not self._builders_are_green() or not self._can_build_and_test() or not self._builders_are_green()):

patch?
 52     "name": "Path1",

Comment 3 Adam Barth 2010-03-15 22:55:50 PDT

Committed r56040: <http://trac.webkit.org/changeset/56040>