Bug 36137

Summary:

[Qt] tst_qwebpage does not pass

Product:

WebKit

Reporter:

Robert Hogan <robert>

Component:

Tools / Tests

Assignee:

QtWebKit Unassigned <webkit-qt-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jwieczorek

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	hausmann: review+

Description Robert Hogan 2010-03-15 14:12:07 PDT

Remove calls to setPage(0) - these were causing tst_qwebpage to
segfault at acceptNavigationRequest() and errorPageExtension*().

Comment 1 Robert Hogan 2010-03-15 14:20:17 PDT

Created attachment 50737 [details]
Patch

Comment 2 Jakub Wieczorek 2010-03-15 14:54:43 PDT

Fixing unstable tests is always a good thing but usually it is better to fix the reason of a failure, I think.

Here is the interesting bit of the crash:

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7022dc2 in QWebView::setPage (this=0x71f3a0, page=0x0) at WebKit/qt/Api/qwebview.cpp:401
401         d->page->d->page->settings()->setAcceleratedCompositingEnabled(false);
(gdb) bt full
#0  0x00007ffff7022dc2 in QWebView::setPage (this=0x71f3a0, page=0x0) at WebKit/qt/Api/qwebview.cpp:401

Comment 3 Robert Hogan 2010-03-15 15:16:00 PDT

Created attachment 50746 [details]
Patch

Actually fix the bug per Jakub's kind suggestion!

Comment 4 Eric Seidel (no email) 2010-03-15 19:02:20 PDT

Comment on attachment 50746 [details]
Patch

Why the indent change?

Comment 5 Robert Hogan 2010-03-16 08:36:26 PDT

Manually committed: http://trac.webkit.org/changeset/56060

Comment 6 Robert Hogan 2010-03-16 08:36:55 PDT

(In reply to comment #4)
> (From update of attachment 50746 [details])
> Why the indent change?

It's moved into an if block.