Bug 36132

Summary: VO not able to perform a VO-spacebar on facebook links
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch bdakin: review+

Description chris fleizach 2010-03-15 13:25:22 PDT 
There are links on facebook that clearly should except a AXPress, but seem to do nothing when using VO-spacebar.

SOme links include:
• "click here to comment"
Comment 1 chris fleizach 2010-03-15 13:37:34 PDT 
Created attachment 50732 [details]
patch
Comment 2 chris fleizach 2010-03-15 13:39:14 PDT 
the w3 specs say that  label element should pass its access key action to its corresponding control, but it doesn't say what happens when there is no corresponding control. it seems like it should handle it itself

an alternative to do this is for accessibility code to stop using accessKeyAction for the "press" action, and instead use dispatchSimulatedClick

the downside to that is that there is a bunhc of logic in subclasses using accessKeyAction on whether the element should take focus first or not
Comment 3 chris fleizach 2010-03-15 15:07:39 PDT 
http://trac.webkit.org/changeset/56019
Comment 4 chris fleizach 2010-03-15 15:17:44 PDT 
for some reason test is failing
Comment 5 chris fleizach 2010-03-15 15:32:55 PDT 
forgot to commit webkit tools changelog
Comment 6 chris fleizach 2010-03-15 15:55:33 PDT 
got mac layout tests working. now to see if i can implement the press action for gtk and windows
Comment 7 chris fleizach 2010-03-15 16:20:27 PDT 
looked like the windows press action did not work. i will skip that test and i filed
https://bugs.webkit.org/show_bug.cgi?id=36145
waiting to see what happens on GTK