[Qt] Make WebKit scrollbars work with tiling

• Component: New Bugs
• Status: RESOLVED FIXED

[Antti Koivisto]

Currently tiling only works correctly when the QGraphicsWebView is in resizesToContent mode. It should work without too, using the scrollbar overlay (already implemented for accelerated compositing).

[Antti Koivisto]

Created attachment 50713 [details]
patch

[Simon Hausmann]

This works quite well now! The vertical scrollbar is broken for me though. Do you see that, too?

[Kenneth Rohde Christiansen]

Nice patch!

[Simon Hausmann]

Comment on attachment 50713 [details]
patch


> +void QGraphicsWebViewPrivate::createOrDeleteOverlay()
> +{
> +    bool useOverlay = false;
> +#if USE(ACCELERATED_COMPOSITING)
> +    useOverlay = useOverlay || rootGraphicsLayer;
> +#endif
> +#if ENABLE(TILED_BACKING_STORE)
> +    useOverlay = useOverlay || QWebFramePrivate::core(q->page()->mainFrame())->tiledBackingStore();

Isn't another condition that we need the overlay only if we're _not_ in resizesToContents mode?

[Antti Koivisto]

(In reply to comment #2)
> This works quite well now! The vertical scrollbar is broken for me though. Do
> you see that, too?

No, both scrollbars look and work fine (this is on mac). Anything special I need to do to see this?

[Antti Koivisto]

Created attachment 50784 [details]
updated patch

[Antti Koivisto]

Comment on attachment 50784 [details]
updated patch

fixed the resizesToContents bug Simon noticed

[Simon Hausmann]

(In reply to comment #5)
> (In reply to comment #2)
> > This works quite well now! The vertical scrollbar is broken for me though. Do
> > you see that, too?
> 
> No, both scrollbars look and work fine (this is on mac). Anything special I
> need to do to see this?

Hmmm, I see it happening on Linux with the Oxygen style. For some reason it doesn't happen with the other styles.

[Simon Hausmann]

Created attachment 50797 [details]
Screenshot

Attached is a screenshot of the bug. It looks like it only affects the vertical scrollbar, and I think that could happen if the geometries passed to are weird.

[Antti Koivisto]

Sending        WebCore/ChangeLog
Sending        WebCore/page/Frame.cpp
Sending        WebKit/qt/Api/qgraphicswebview.cpp
Sending        WebKit/qt/Api/qwebframe.cpp
Sending        WebKit/qt/Api/qwebframe_p.h
Sending        WebKit/qt/ChangeLog
Transmitting file data ......
Committed revision 56068.