Bug 36112

Summary: Make PlatformMedia a typedef
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: eric.carlson, gustavo, jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch none

Philippe Normand
Reported 2010-03-15 03:01:31 PDT
From Bug 35333, interesting comments especially in https://bugs.webkit.org/show_bug.cgi?id=35333#c8 and https://bugs.webkit.org/show_bug.cgi?id=35333#c10
Attachments
proposed patch (11.67 KB, patch)
2010-05-10 03:04 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-05-10 02:48:07 PDT
I will send a patch to make PlatformMedia a typedef. As I think we agreed with Eric (correct me if I'm wrong!) it doesn't make much sense for it to be a structure.
Philippe Normand
Comment 2 2010-05-10 03:04:18 PDT
Created attachment 55533 [details] proposed patch
Jer Noble
Comment 3 2010-05-10 07:35:06 PDT
Phillipe, please take a look at the patch in https://bugs.webkit.org/show_bug.cgi?id=38689. Windows WebCore now has multiple MediaPlayerPrivate engines created at runtime, each which needs to return a different type of PlatformMedia. Defining these types at compile-time by platform doesn't allow this. But adding a GStreamer specific type to the struct in the patch above would be very simple.
Philippe Normand
Comment 4 2010-05-10 07:51:40 PDT
Ah well... then I guess I should mark this bug as invalid. For GStreamer the PlatformMedia stuff doesn't help much. I plan to propose a new API in the MediaPlayer to enter/exit fullscreen. The player would provide to the "client" a PlatformFullscreenWindow pointer. Anyway this is for another bug :)
Note You need to log in before you can comment on or make changes to this bug.