Bug 36072

Summary: [OpenVG] Add support for decoding and drawing images
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: PlatformAssignee: Jakob Petsovits <jpetsovits>
Status: RESOLVED FIXED    
Severity: Normal CC: elongbug, eric, krit, staikos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Bug Depends on:    
Bug Blocks: 33987    
Attachments:
Description Flags
Patch
none
Patch staikos: review+

Jakob Petsovits
Reported 2010-03-12 14:16:06 PST
Image support is still missing in the OpenVG backend (as is ImageBuffer and lots of features, but those are subject to future bugs). As you might guess, this patch has a shot at that shortcoming. It's currently duplicating memory - both the decoded buffer and the VGImage are storing the same pixel data, which is bad. But the patch is large enough already, so I'll wait with the "better" version until this one has been landed. Image pattern drawing for arbitrary-size images is also not quite trivial and will come in a follow-up patch as well.
Attachments
Patch (30.32 KB, patch)
2010-03-12 14:18 PST, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Patch (30.41 KB, patch)
2010-03-29 08:56 PDT, Jakob Petsovits 		staikos: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2010-03-12 14:18:02 PST
Created attachment 50633 [details] Patch
Jakob Petsovits
Comment 2 2010-03-29 08:56:41 PDT
Created attachment 51918 [details] Patch
Jakob Petsovits
Comment 3 2010-03-29 08:58:37 PDT
The above fixes a couple of issues noticed by Dirk, who suggests that Olliej or someone else should take a look at this patch as well. Still waiting for review, thanks!
George Staikos
Comment 4 2010-04-06 19:53:14 PDT
Looks good, and I know you have some additional patches to follow this which I hope will show up quickly. :)
Eric Seidel (no email)
Comment 5 2010-04-06 23:44:59 PDT
Attachment 51918 [details] was posted by a committer and has review+, assigning to Jakob Petsovits for commit.
Eric Seidel (no email)
Comment 6 2010-05-17 00:55:42 PDT
Looks like this has been in pending-commit for over a month. Did this get landed already? Should it just be commit-queued?
Jakob Petsovits
Comment 7 2010-05-17 11:23:46 PDT
Was not landed yet. I'll land it today, and will try harder to get the rest of OpenVG patches upstream as well.
Jakob Petsovits
Comment 8 2010-05-17 12:11:45 PDT
Committed r59619: <http://trac.webkit.org/changeset/59619>
Note You need to log in before you can comment on or make changes to this bug.