Bug 36069

Summary:

Eliminate InlineRunBox

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch to remove InlineRunBox	mitz: review+, hyatt: commit-queue-

Description Dave Hyatt 2010-03-12 11:54:04 PST

It's an unnecessary class that is complicating the line box hierarchy.  It needs to go.

Comment 1 Dave Hyatt 2010-03-12 12:12:38 PST

Created attachment 50620 [details]
Patch to remove InlineRunBox

Comment 2 WebKit Review Bot 2010-03-12 12:17:38 PST

Attachment 50620 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WARNING: Could not read file. Skipping: "WebCore/rendering/InlineRunBox.h"
WebCore/rendering/RenderLineBoxList.cpp:324:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/rendering/InlineFlowBox.h:176:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/InlineFlowBox.h:177:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/InlineTextBox.h:123:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/InlineTextBox.h:124:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 5 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Dave Hyatt 2010-03-12 12:30:05 PST

Fixed in r55928.