Bug 36050

Summary:

Add the possibility for a head and footer section to create_jit_stubs

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, eric, laszlo.gombos, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Bug Depends on:

Bug Blocks:

34953

Attachments:

Description	Flags
The patch	none

Patrick R. Gansterer

Reported 2010-03-12 00:21:11 PST

see patch

Attachments
The patch (1.53 KB, patch) 2010-03-12 00:22 PST, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Patrick R. Gansterer

Comment 1 2010-03-12 00:22:30 PST

Created attachment 50580 [details] The patch

Laszlo Gombos

Comment 2 2010-03-12 05:37:52 PST

Patrick, can you describe the motivation behind this change ? Which port will use this feature and how will this feature will be used ? Thanks.

Patrick R. Gansterer

Comment 3 2010-03-12 05:41:25 PST

(In reply to comment #2) > Patrick, can you describe the motivation behind this change ? Which port will > use this feature and how will this feature will be used? Thanks. It's for bug 34953. I need to insert sth before and sth after the DEFINE_STUB_FUNCTION.

Eric Seidel (no email)

Comment 4 2010-03-15 15:22:04 PDT

Comment on attachment 50580 [details] The patch The ChangeLog should really explain the "why". Comments in the bug are nice, but not as accessible during reviews or during later svn annotates.

Eric Seidel (no email)

Comment 5 2010-03-25 01:43:30 PDT

CCing the JIT ninjas.

Eric Seidel (no email)

Comment 6 2010-05-09 14:54:48 PDT

Comment on attachment 50580 [details] The patch Is this used for anything? How can this be tested, or at least proven to do something useful. :)

Patrick R. Gansterer

Comment 7 2010-05-09 15:05:27 PDT

(In reply to comment #6) > (From update of attachment 50580 [details]) > Is this used for anything? How can this be tested, or at least proven to do something useful. :) This is only necessary for bug 34953. The assembler file for WinCE ARM JIT needs a part before (at least " AREA Trampoline, CODE") and a part after the "DEFINE_STUB_FUNCTION implementations" (" END"). Maybe you have a better solution for this?? Otherwise it can be useful ;-)

WebKit Commit Bot

Comment 8 2010-06-25 00:30:27 PDT

Comment on attachment 50580 [details] The patch Clearing flags on attachment: 50580 Committed r61838: <http://trac.webkit.org/changeset/61838>

WebKit Commit Bot

Comment 9 2010-06-25 00:30:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.