| Summary: | More open-source image decoder cleanup | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peter Kasting <pkasting> | ||||||
| Component: | Images | Assignee: | Peter Kasting <pkasting> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Peter Kasting
2010-03-11 16:33:39 PST
Created attachment 50560 [details]
patch v1
Details on the ChangeLog. Half of this is making things simpler, the other half is making things consistent between the different decoders.
Attachment 50560 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:144: num_bytes is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 50561 [details]
patch v2
It's always a judgment call which style issues in the JPEGImageDecoder file to fix; fixed this one because it's our member function rather than one of the C API functions libjpeg calls directly.
Comment on attachment 50561 [details]
patch v2
Nice.
|