Bug 36032

Summary: rebaseline_chromium_webkit_tests doesn't handle port correctly
Product: WebKit Reporter: Victor Wang <victorw>
Component: Tools / TestsAssignee: Victor Wang <victorw>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dpranke, hamaji, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed patch
none
Fixed tab in ChangeLog dglazkov: review+

Victor Wang
Reported 2010-03-11 14:20:16 PST
Rebaseline_chromium_webkit_tests does not handle port correctly. It needs to have two ports in Rebaseliner: one is the port the script is running on and another one for the port to be rebaselined. For more details, see comments in https://bugs.webkit.org/show_bug.cgi?id=35982.
Attachments
Proposed patch (3.61 KB, patch)
2010-03-11 14:54 PST, Victor Wang 		no flags
DetailsFormatted DiffDiff
Fixed tab in ChangeLog (3.62 KB, patch)
2010-03-11 14:56 PST, Victor Wang 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Victor Wang
Comment 1 2010-03-11 14:54:03 PST
Created attachment 50547 [details] Proposed patch
Victor Wang
Comment 2 2010-03-11 14:56:16 PST
Created attachment 50548 [details] Fixed tab in ChangeLog
Victor Wang
Comment 3 2010-03-11 16:12:37 PST
Hi Dirk, Could you take a look at this patch? Thanks!
Dirk Pranke
Comment 4 2010-03-11 16:31:55 PST
Comment on attachment 50548 [details] Fixed tab in ChangeLog Looks more or less correct. Assuming you've tested this, LGTM.
Dimitri Glazkov (Google)
Comment 5 2010-03-11 16:32:57 PST
Comment on attachment 50548 [details] Fixed tab in ChangeLog ok!
Victor Wang
Comment 6 2010-03-11 16:51:36 PST
Committed r55868: <http://trac.webkit.org/changeset/55868>
Note You need to log in before you can comment on or make changes to this bug.