Bug 36032 - rebaseline_chromium_webkit_tests doesn't handle port correctly
Summary: rebaseline_chromium_webkit_tests doesn't handle port correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Victor Wang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-11 14:20 PST by Victor Wang
Modified: 2010-03-11 16:51 PST (History)
4 users (show)

See Also:

Attachments
Proposed patch (3.61 KB, patch)
2010-03-11 14:54 PST, Victor Wang 		no flags Details | Formatted Diff | Diff
Fixed tab in ChangeLog (3.62 KB, patch)
2010-03-11 14:56 PST, Victor Wang 		dglazkov: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Wang 2010-03-11 14:20:16 PST 
Rebaseline_chromium_webkit_tests does not handle port correctly. It needs to have two ports in Rebaseliner: one is the port the script is running on and another one for the port to be rebaselined. For more details, see comments in https://bugs.webkit.org/show_bug.cgi?id=35982.
Comment 1 Victor Wang 2010-03-11 14:54:03 PST 
Created attachment 50547 [details]
Proposed patch
Comment 2 Victor Wang 2010-03-11 14:56:16 PST 
Created attachment 50548 [details]
Fixed tab in ChangeLog
Comment 3 Victor Wang 2010-03-11 16:12:37 PST 
Hi Dirk,
Could you take a look at this patch? Thanks!
Comment 4 Dirk Pranke 2010-03-11 16:31:55 PST 
Comment on attachment 50548 [details]
Fixed tab in ChangeLog

Looks more or less correct. Assuming you've tested this, LGTM.
Comment 5 Dimitri Glazkov (Google) 2010-03-11 16:32:57 PST 
Comment on attachment 50548 [details]
Fixed tab in ChangeLog

ok!
Comment 6 Victor Wang 2010-03-11 16:51:36 PST 
Committed r55868: <http://trac.webkit.org/changeset/55868>