Bug 36026

Summary:

[v8] Add V8 bindings for DOMFormData

Product:

WebKit

Reporter:

Jian Li <jianli>

Component:

WebCore Misc.

Assignee:

Jian Li <jianli>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, dimich, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

36024

Bug Blocks:

Attachments:

Description	Flags
Proposed Patch	jianli: commit-queue-
Fix style error	japhet: review-, jianli: commit-queue-
Proposed Patch	japhet: review+, jianli: commit-queue-

Description Jian Li 2010-03-11 12:01:16 PST

Need to add V8 bindings for DOMFormData.

Comment 1 Jian Li 2010-03-11 12:05:06 PST

Created attachment 50526 [details]
Proposed Patch

Comment 2 Jian Li 2010-03-11 12:06:58 PST

This patch depends on the patch for 36024. The chromium builder might show broken due to that patch 36024 is not landed.

I will check in this patch immediately after landing patch for 36024.

Comment 3 WebKit Review Bot 2010-03-11 12:08:08 PST

Attachment 50526 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Jian Li 2010-03-11 12:10:53 PST

Created attachment 50528 [details]
Fix style error

Comment 5 WebKit Review Bot 2010-03-11 12:12:15 PST

Attachment 50526 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/642025

Comment 6 WebKit Review Bot 2010-03-11 12:30:32 PST

Attachment 50528 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/623019

Comment 7 Nate Chapin 2010-03-11 16:48:25 PST

Comment on attachment 50528 [details]
Fix style error

Looks good in general.  However, I don't see DOMFormData.idl anywhere.  I assume that's why the EWS failed to build?

A couple additional minor things:

> diff --git a/WebCore/bindings/v8/DOMObjectsInclude.h b/WebCore/bindings/v8/DOMObjectsInclude.h
> index cd8443a..fd1a875 100644
> --- a/WebCore/bindings/v8/DOMObjectsInclude.h
> +++ b/WebCore/bindings/v8/DOMObjectsInclude.h
> @@ -82,6 +82,7 @@
>  #include "DocumentType.h"
>  #include "DocumentFragment.h"
>  #include "DOMCoreException.h"
> +#include "DOMFormData.h"
>  #include "DOMImplementation.h"
>  #include "DOMParser.h"
>  #include "DOMSelection.h"

I deleted this file today, since it wasn't getting much use.  Feel free to revert this part of the change.

> diff --git a/WebCore/bindings/v8/DerivedSourcesAllInOne.cpp b/WebCore/bindings/v8/DerivedSourcesAllInOne.cpp
> index b626499..76ad172 100644
> --- a/WebCore/bindings/v8/DerivedSourcesAllInOne.cpp
> +++ b/WebCore/bindings/v8/DerivedSourcesAllInOne.cpp
> @@ -94,6 +94,7 @@
>  #include "bindings/V8DocumentFragment.cpp"
>  #include "bindings/V8DocumentType.cpp"
>  #include "bindings/V8DOMCoreException.cpp"
> +#include "bindings/V8DOMFormData.cpp"
>  #include "bindings/V8DOMImplementation.cpp"
>  #include "bindings/V8DOMParser.cpp"
>  #include "bindings/V8DOMSelection.cpp"

This file is current unused and about to be deleted as well.

Comment 8 Jian Li 2010-03-11 16:57:02 PST

The idl is in the patch for bug 36024.

Comment 9 Jian Li 2010-03-11 17:04:39 PST

Created attachment 50562 [details]
Proposed Patch

Revert changes done to the removed file and the file to be removed.

Comment 10 WebKit Review Bot 2010-03-11 17:11:08 PST

Attachment 50562 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/588032

Comment 11 Nate Chapin 2010-03-11 17:35:57 PST

Comment on attachment 50562 [details]
Proposed Patch

Excellent, thanks for the clarification.

Comment 12 Jian Li 2010-03-15 10:37:55 PDT

Committed as http://trac.webkit.org/changeset/56004.