Summary: | accessibilityIsIgnoredBase() needs to respect when platform says include | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||||
Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, dglazkov, gustavo, jdiggs, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
chris fleizach
2010-03-11 11:59:27 PST
accessibilityIsIgnoredBased() needs to return a ternary value Created attachment 50532 [details]
Patch
Attachment 50532 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/618023 Created attachment 50533 [details]
Patch
Comment on attachment 50533 [details] Patch > -#if PLATFORM(GTK) > - return true; > -#endif Are you sure you want to remove this? r=me (In reply to comment #5) > (From update of attachment 50533 [details]) > > -#if PLATFORM(GTK) > > - return true; > > -#endif > > Are you sure you want to remove this? > Yea, i looked at what was going on. GTK wants the platform to decide the fate of that object. Now that that object calls accessibilityIsIgnoredBase(), that's now taken care of > r=me Thanks for the quick fix! Much appreciated =). |