Bug 36025

Summary: accessibilityIsIgnoredBase() needs to respect when platform says include
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, dglazkov, gustavo, jdiggs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch bdakin: review+

Description chris fleizach 2010-03-11 11:59:27 PST
accessibilityIsIgnoredBase() is not doing this, so when an object is always included by a platform, its not working
Comment 1 chris fleizach 2010-03-11 12:33:54 PST
accessibilityIsIgnoredBased() needs to return a ternary value
Comment 2 chris fleizach 2010-03-11 12:56:04 PST
Created attachment 50532 [details]
Patch
Comment 3 WebKit Review Bot 2010-03-11 13:01:31 PST
Attachment 50532 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/618023
Comment 4 chris fleizach 2010-03-11 13:05:33 PST
Created attachment 50533 [details]
Patch
Comment 5 Beth Dakin 2010-03-11 14:02:50 PST
Comment on attachment 50533 [details]
Patch

> -#if PLATFORM(GTK)
> -    return true;
> -#endif

Are you sure you want to remove this?

r=me
Comment 6 chris fleizach 2010-03-11 14:18:26 PST
(In reply to comment #5)
> (From update of attachment 50533 [details])
> > -#if PLATFORM(GTK)
> > -    return true;
> > -#endif
> 
> Are you sure you want to remove this?
> 
 Yea, i looked at what was going on. GTK wants the platform to decide the fate of that object. Now that that object calls accessibilityIsIgnoredBase(), that's now taken care of

> r=me
Comment 7 chris fleizach 2010-03-11 14:33:41 PST
http://trac.webkit.org/changeset/55855
Comment 8 Gustavo Noronha (kov) 2010-03-12 06:33:16 PST
Thanks for the quick fix! Much appreciated =).