Bug 36014

Summary: Combine ctiTrampolines related to different JSValue representation
Product: WebKit Reporter: Gabor Loki <loki>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: barraclough, commit-queue, laszlo.gombos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Combine ctiTrampolines on ARM and Thumb-2
none
Combine ctiTrampolines on ARM and Thumb-2 (v2) none

Gabor Loki
Reported 2010-03-11 07:19:15 PST
Created attachment 50496 [details] Combine ctiTrampolines on ARM and Thumb-2 The bug 34939 showed, the copy-paste code and hand coded constants can simply lead to an error. We should try to combine them. I have created a patch for ARM and Thumb-2. A similar construct can be used for other backends.
Attachments
Combine ctiTrampolines on ARM and Thumb-2 (14.82 KB, patch)
2010-03-11 07:19 PST, Gabor Loki 		no flags
DetailsFormatted DiffDiff
Combine ctiTrampolines on ARM and Thumb-2 (v2) (14.83 KB, patch)
2010-03-11 07:25 PST, Gabor Loki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gabor Loki
Comment 1 2010-03-11 07:25:43 PST
Created attachment 50499 [details] Combine ctiTrampolines on ARM and Thumb-2 (v2) Fixed some style issues.
WebKit Review Bot
Comment 2 2010-03-11 07:26:34 PST
Attachment 50496 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] JavaScriptCore/jit/JITStubs.cpp:593: Extra space before ( in function call [whitespace/parens] [4] JavaScriptCore/jit/JITStubs.cpp:620: Extra space before ( in function call [whitespace/parens] [4] JavaScriptCore/jit/JITStubs.cpp:638: Extra space before ( in function call [whitespace/parens] [4] JavaScriptCore/jit/JITStubs.cpp:656: Extra space before ( in function call [whitespace/parens] [4] JavaScriptCore/jit/JITStubs.cpp:674: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 3 2010-03-15 00:15:41 PDT
Comment on attachment 50499 [details] Combine ctiTrampolines on ARM and Thumb-2 (v2) Awesome patch Gabor, we have to do this for all archs. Very nice.
WebKit Commit Bot
Comment 4 2010-03-15 09:33:31 PDT
Comment on attachment 50499 [details] Combine ctiTrampolines on ARM and Thumb-2 (v2) Clearing flags on attachment: 50499 Committed r56000: <http://trac.webkit.org/changeset/56000>
WebKit Commit Bot
Comment 5 2010-03-15 09:33:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.