Summary: | Send the frame URL on GeolocationServiceBridgeImpl::startUpdating. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Marcus Bulach <bulach> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, jorlow, joth | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Marcus Bulach
2010-03-11 06:09:19 PST
This change adds URL when calling GeolocationServiceBridgeImpl::startUpdating so that the embedder can decide whether or not the origin is authorized before actually sending any geoposition. Created attachment 50502 [details]
Patch
Comment on attachment 50502 [details] Patch > Index: WebKit/chromium/public/GeolocationServiceBridgeChromium.h > =================================================================== > --- WebKit/chromium/public/GeolocationServiceBridgeChromium.h (revision 55784) > +++ WebKit/chromium/public/GeolocationServiceBridgeChromium.h (working copy) > @@ -53,7 +53,7 @@ public: > class WebGeolocationServiceInterface { > public: > virtual void requestPermissionForFrame(int bridgeId, const WebURL& url) = 0; > - virtual void startUpdating(int bridgeId, bool hasHighAccuracy) = 0; > + virtual void startUpdating(int bridgeId, const WebURL& url, bool hasHighAccuracy) = 0; Nit: I'm not sure if there's a webkit convention on this, but wantsHighAccuracy would be closer to the intending meaning than hasHighAccuracy Created attachment 50505 [details]
Patch
Comment on attachment 50505 [details]
Patch
r=me
Comment on attachment 50505 [details] Patch Clearing flags on attachment: 50505 Committed r56011: <http://trac.webkit.org/changeset/56011> All reviewed patches have been landed. Closing bug. Comment on attachment 50505 [details] Patch > Index: WebKit/chromium/src/GeolocationServiceBridgeChromium.cpp ... > + getWebViewClient()->getGeolocationService()->startUpdating(m_bridgeId, m_GeolocationServiceChromium->frame()->document()->url(), positionOptions->enableHighAccuracy()); please note that the WebViewClient can be null! |