Bug 36012

Summary: Send the frame URL on GeolocationServiceBridgeImpl::startUpdating.
Product: WebKit Reporter: Marcus Bulach <bulach>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jorlow, joth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Marcus Bulach
Reported 2010-03-11 06:09:19 PST
Send the frame URL on GeolocationServiceBridgeImpl::startUpdating.
Attachments
Patch (2.30 KB, patch)
2010-03-11 07:34 PST, Marcus Bulach 		no flags
DetailsFormatted DiffDiff
Patch (2.30 KB, patch)
2010-03-11 07:59 PST, Marcus Bulach 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Marcus Bulach
Comment 1 2010-03-11 07:25:24 PST
This change adds URL when calling GeolocationServiceBridgeImpl::startUpdating so that the embedder can decide whether or not the origin is authorized before actually sending any geoposition.
Marcus Bulach
Comment 2 2010-03-11 07:34:08 PST
Created attachment 50502 [details] Patch
Jonathan Dixon
Comment 3 2010-03-11 07:47:29 PST
Comment on attachment 50502 [details] Patch > Index: WebKit/chromium/public/GeolocationServiceBridgeChromium.h > =================================================================== > --- WebKit/chromium/public/GeolocationServiceBridgeChromium.h (revision 55784) > +++ WebKit/chromium/public/GeolocationServiceBridgeChromium.h (working copy) > @@ -53,7 +53,7 @@ public: > class WebGeolocationServiceInterface { > public: > virtual void requestPermissionForFrame(int bridgeId, const WebURL& url) = 0; > - virtual void startUpdating(int bridgeId, bool hasHighAccuracy) = 0; > + virtual void startUpdating(int bridgeId, const WebURL& url, bool hasHighAccuracy) = 0; Nit: I'm not sure if there's a webkit convention on this, but wantsHighAccuracy would be closer to the intending meaning than hasHighAccuracy
Marcus Bulach
Comment 4 2010-03-11 07:59:59 PST
Created attachment 50505 [details] Patch
Jeremy Orlow
Comment 5 2010-03-11 08:01:15 PST
Comment on attachment 50505 [details] Patch r=me
WebKit Commit Bot
Comment 6 2010-03-15 13:30:25 PDT
Comment on attachment 50505 [details] Patch Clearing flags on attachment: 50505 Committed r56011: <http://trac.webkit.org/changeset/56011>
WebKit Commit Bot
Comment 7 2010-03-15 13:30:30 PDT
All reviewed patches have been landed. Closing bug.
Darin Fisher (:fishd, Google)
Comment 8 2010-03-23 13:09:39 PDT
Comment on attachment 50505 [details] Patch > Index: WebKit/chromium/src/GeolocationServiceBridgeChromium.cpp ... > + getWebViewClient()->getGeolocationService()->startUpdating(m_bridgeId, m_GeolocationServiceChromium->frame()->document()->url(), positionOptions->enableHighAccuracy()); please note that the WebViewClient can be null!
Note You need to log in before you can comment on or make changes to this bug.