Summary: | Enhance Windows DRT implementation to support platform scroll wheel events. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||
Component: | Tools / Tests | Assignee: | Per Arne Vollan <pvollan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Enhancement | CC: | aestes, bfulgham, pvollan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Andy Estes
2010-03-10 21:55:40 PST
Created attachment 282770 [details]
Patch
Comment on attachment 282770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282770&action=review These changes look good. I feel like the 'continuousMouseScrollBy' is just the first step in actually supporting that behavior, so I'm not being too picky about how it works at the moment. > Tools/DumpRenderTree/win/EventSender.cpp:818 > + double deltaX = JSValueToNumber(context, arguments[0], exception); Whoops! I wonder if that caused any crashes .... > Tools/DumpRenderTree/win/EventSender.cpp:850 > +} I don't understand what makes 'continuousMouseScrollBy' different than just the regular 'mouseScrollBy'. Maybe that's why the tests are still failing after this change? (In reply to comment #2) > Comment on attachment 282770 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282770&action=review > > These changes look good. I feel like the 'continuousMouseScrollBy' is just > the first step in actually supporting that behavior, so I'm not being too > picky about how it works at the moment. > > > Tools/DumpRenderTree/win/EventSender.cpp:818 > > + double deltaX = JSValueToNumber(context, arguments[0], exception); > > Whoops! I wonder if that caused any crashes .... > > > Tools/DumpRenderTree/win/EventSender.cpp:850 > > +} > > I don't understand what makes 'continuousMouseScrollBy' different than just > the regular 'mouseScrollBy'. Maybe that's why the tests are still failing > after this change? Thanks for reviewing! I think the scroll unit is pixels in 'continuousMouseScrollBy', while it is lines in 'mouseScrollBy'. Committed r202849: <https://trac.webkit.org/changeset/202849> |