Bug 36001
| Summary: | SQLiteFileSystem::ensureDatabaseFileExists() doesn't do what it supposed to do. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lyon Chen <lyon.chen> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | yong.li.webkit |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Lyon Chen
For SQLiteFileSystem::ensureDatabaseFileExists(const String& fileName, bool checkPathOnly), the second parameter is checkPathOnly and it means check path only when it's true, but the only place it's called is DatabaseTracker::openTrackerDatabase(), which calls ensureDatabaseFileExists() with parameter createIfDoesNotExist and it expect the file will be created if it doesn't existed already.
I think SQLiteFileSystem::ensureDatabaseFileExists() should be changed to do as its function name indicates, create the file if it's not existed already.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lyon Chen
My bad, it's not a bug.
Yong Li
close it