Summary: | [Chromium] Popup font size needs to be exposed to clients. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Scott Byer <scottbyer> | ||||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, darin, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Scott Byer
2010-03-10 15:26:12 PST
Created attachment 50453 [details]
Proposed patch.
Attachment 50453 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
ChangeLog:10: Line contains tab character. [whitespace/tab] [5]
Total errors found: 3 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 50455 [details]
Proposed patch (style fixed).
Comment on attachment 50455 [details] Proposed patch (style fixed). > Index: ChangeLog ... > + WebPopupMenuInfo that recieves that information to convey that to nit: s/recieves/receives/ otherwise, r=me post a revised patch, and then i'll mark it cq+ so it'll get committed. thanks! Created attachment 50468 [details]
Proposed patch (with spelling fixed).
Comment on attachment 50468 [details] Proposed patch (with spelling fixed). Clearing flags on attachment: 50468 Committed r55897: <http://trac.webkit.org/changeset/55897> All reviewed patches have been landed. Closing bug. |