Bug 35990

Summary: [Chromium] Popup font size needs to be exposed to clients.
Product: WebKit Reporter: Scott Byer <scottbyer>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue, darin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Description Flags
Proposed patch.
Proposed patch (style fixed).
fishd: review+, fishd: commit-queue-
Proposed patch (with spelling fixed). none

Description Scott Byer 2010-03-10 15:26:12 PST
In the case where a WebKit client wants to implement a combobox/popup elsewhere, the font size needs to be exposed so that the popped up menu can match the font size being used on the page at the current zoom.

See http://crbug.com/14010

I am working on this bug (scottbyer@chromium.org)
Comment 1 Scott Byer 2010-03-10 16:29:24 PST
Created attachment 50453 [details]
Proposed patch.
Comment 2 WebKit Review Bot 2010-03-10 16:33:43 PST
Attachment 50453 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Scott Byer 2010-03-10 16:35:41 PST
Created attachment 50455 [details]
Proposed patch (style fixed).
Comment 4 Darin Fisher (:fishd, Google) 2010-03-10 19:50:21 PST
Comment on attachment 50455 [details]
Proposed patch (style fixed).

> Index: ChangeLog
> +        WebPopupMenuInfo that recieves that information to convey that to

nit: s/recieves/receives/

otherwise, r=me

post a revised patch, and then i'll mark it cq+ so it'll get committed.  thanks!
Comment 5 Scott Byer 2010-03-10 20:52:57 PST
Created attachment 50468 [details]
Proposed patch (with spelling fixed).
Comment 6 WebKit Commit Bot 2010-03-12 07:11:00 PST
Comment on attachment 50468 [details]
Proposed patch (with spelling fixed).

Clearing flags on attachment: 50468

Committed r55897: <http://trac.webkit.org/changeset/55897>
Comment 7 WebKit Commit Bot 2010-03-12 07:11:04 PST
All reviewed patches have been landed.  Closing bug.