Bug 35950 – [chromium] Screen coordinate flipping in Chromium Mac event conversion should use primary monitor

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Stuart Morgan]

Screen-coordinate flipping should be based on the primary monitor (the one with the menu bar), but currently the Chromium event factory code is using the screen that the window is on.

This has mostly worked out before because we have the same bug in the window frame conversion: http://codereview.chromium.org/751002
I'll coordinate with the WebKit gardner to get both patches in at the same time.

[Stuart Morgan]

Created attachment 50360 [details]
Fix

Fixes the bug, and eliminates the duplicate location conversion code between mouse events and mouse wheel events. Also fixes the way the global coordinates are calculated so that it actually uses the passed event, rather than the current location of the mouse.

[Darin Fisher (:fishd, Google)]

Comment on attachment 50360 [details]
Fix

Since this is a dual-sided patch, I'm assuming you need to
coordinate this landing with the appropriate webkit gardener.

[Nate Chapin]

Comment on attachment 50360 [details]
Fix

I'm the appropriate chromium webkit gardener, and I think this is a good time for this patch, so switching to cq+

[WebKit Commit Bot]

Comment on attachment 50360 [details]
Fix

Clearing flags on attachment: 50360

Committed r55877: <http://trac.webkit.org/changeset/55877>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.