Bug 35945

Summary:

Web Inspector: Audits panel needs an icon

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Icon	none
[IMAGE] Screenshot while running with icon.	none
Icon (White)	none
[PATCH] White icon patch.	timothy: review+
[IMAGE] Screenshot with white icon.	none

Timothy Hatcher

Reported 2010-03-09 14:33:05 PST

Add an icon for the audits panel.

Attachments
Icon (2.27 KB, image/png) 2010-03-10 04:14 PST, Timothy Hatcher	no flags	Details
[IMAGE] Screenshot while running with icon. (53.71 KB, image/png) 2010-03-10 05:44 PST, Pavel Feldman	no flags	Details
Icon (White) (3.73 KB, image/png) 2010-03-10 10:24 PST, Timothy Hatcher	no flags	Details
[PATCH] White icon patch. (7.22 KB, patch) 2010-03-10 10:56 PST, Pavel Feldman	timothy: review+	Details Formatted Diff Diff
[IMAGE] Screenshot with white icon. (32.51 KB, image/png) 2010-03-10 10:57 PST, Pavel Feldman	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2010-03-10 04:14:46 PST

Created attachment 50390 [details] Icon How is this?

Pavel Feldman

Comment 2 2010-03-10 05:44:45 PST

Created attachment 50394 [details] [IMAGE] Screenshot while running with icon. I am ready to land it like this, but it seems like new icon has a yellow baseline and hence does not belong to the existing white-based set. See the screenshot attached.

Timothy Hatcher

Comment 3 2010-03-10 10:01:02 PST

The yellow was intended. I can try white.

Timothy Hatcher

Comment 4 2010-03-10 10:24:33 PST

Created attachment 50414 [details] Icon (White)

Timothy Hatcher

Comment 5 2010-03-10 10:24:56 PST

Does this look better to you?

Pavel Feldman

Comment 6 2010-03-10 10:52:44 PST

(In reply to comment #5) > Does this look better to you? Yes, definitely better.

Pavel Feldman

Comment 7 2010-03-10 10:56:24 PST

Created attachment 50415 [details] [PATCH] White icon patch.

Pavel Feldman

Comment 8 2010-03-10 10:57:34 PST

Created attachment 50416 [details] [IMAGE] Screenshot with white icon.

Pavel Feldman

Comment 9 2010-03-10 11:17:24 PST

panelCount++ Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/WebCore.gypi A WebCore/inspector/front-end/Images/auditsIcon.png M WebCore/inspector/front-end/Settings.js M WebCore/inspector/front-end/WebKit.qrc M WebCore/inspector/front-end/inspector.css Committed r55790

Note You need to log in before you can comment on or make changes to this bug.