Bug 35945 - Web Inspector: Audits panel needs an icon
Summary: Web Inspector: Audits panel needs an icon
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-09 14:33 PST by Timothy Hatcher
Modified: 2010-03-10 11:17 PST (History)
7 users (show)

See Also:


Attachments
Icon (2.27 KB, image/png)
2010-03-10 04:14 PST, Timothy Hatcher
no flags Details
[IMAGE] Screenshot while running with icon. (53.71 KB, image/png)
2010-03-10 05:44 PST, Pavel Feldman
no flags Details
Icon (White) (3.73 KB, image/png)
2010-03-10 10:24 PST, Timothy Hatcher
no flags Details
[PATCH] White icon patch. (7.22 KB, patch)
2010-03-10 10:56 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff
[IMAGE] Screenshot with white icon. (32.51 KB, image/png)
2010-03-10 10:57 PST, Pavel Feldman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2010-03-09 14:33:05 PST
Add an icon for the audits panel.
Comment 1 Timothy Hatcher 2010-03-10 04:14:46 PST
Created attachment 50390 [details]
Icon

How is this?
Comment 2 Pavel Feldman 2010-03-10 05:44:45 PST
Created attachment 50394 [details]
[IMAGE] Screenshot while running with icon.

I am ready to land it like this, but it seems like new icon has a yellow baseline and hence does not belong to the existing white-based set. See the screenshot attached.
Comment 3 Timothy Hatcher 2010-03-10 10:01:02 PST
The yellow was intended. I can try white.
Comment 4 Timothy Hatcher 2010-03-10 10:24:33 PST
Created attachment 50414 [details]
Icon (White)
Comment 5 Timothy Hatcher 2010-03-10 10:24:56 PST
Does this look better to you?
Comment 6 Pavel Feldman 2010-03-10 10:52:44 PST
(In reply to comment #5)
> Does this look better to you?

Yes, definitely better.
Comment 7 Pavel Feldman 2010-03-10 10:56:24 PST
Created attachment 50415 [details]
[PATCH] White icon patch.
Comment 8 Pavel Feldman 2010-03-10 10:57:34 PST
Created attachment 50416 [details]
[IMAGE] Screenshot with white icon.
Comment 9 Pavel Feldman 2010-03-10 11:17:24 PST
panelCount++

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/WebCore.gypi
	A	WebCore/inspector/front-end/Images/auditsIcon.png
	M	WebCore/inspector/front-end/Settings.js
	M	WebCore/inspector/front-end/WebKit.qrc
	M	WebCore/inspector/front-end/inspector.css
Committed r55790