Bug 35911

Summary: Baby steps towards IndexedDB: Start implementing callbacks.
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Severity: Normal CC: dglazkov, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Description Flags
patch dglazkov: review+

Description Jeremy Orlow 2010-03-09 04:47:13 PST
This patch adds some infastructure for IndexedDB callbacks in V8.
        It also adds a stub of IDBDatabaseRequest.  In the near future, 
        I'll gut the event based implementation code, flesh out IDBReqest
        further, and start plumbing IndexedDatabaseRequest.

        Code is not testible because it doesn't work (yet).
Comment 1 Jeremy Orlow 2010-03-09 04:51:45 PST
Created attachment 50294 [details]
Comment 2 WebKit Review Bot 2010-03-09 04:56:00 PST
Attachment 50294 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/custom/V8CustomIDBCallback.h:92:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 10 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dimitri Glazkov (Google) 2010-03-09 13:51:05 PST
Comment on attachment 50294 [details]

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index 92d76a9..9e2ecc4 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,33 @@
> +2010-03-09  Jeremy Orlow  <jorlow@chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Baby steps towards IndexedDB: Start implementing callbacks.
> +        Need a short description and bug URL (OOPS!)

Oops indeed.

ok otherwise.