Bug 35909

Summary: [GTK] GTK_WIDGET_IS_SENSITIVE is deprecated in GTK+ 2.20
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch
zecke: review-
updated patch
none
updated patch zecke: review+

Philippe Normand
Reported 2010-03-09 03:24:26 PST
We should use gtk_widget_is_sensitive() instead if GTK version is >= 2.18.
Attachments
proposed patch (1.59 KB, patch)
2010-03-09 03:29 PST, Philippe Normand 		zecke: review-
DetailsFormatted DiffDiff
updated patch (1.66 KB, patch)
2010-03-10 00:10 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
updated patch (1.66 KB, patch)
2010-03-10 00:11 PST, Philippe Normand 		zecke: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-03-09 03:29:03 PST
Created attachment 50287 [details] proposed patch
Holger Freyther
Comment 2 2010-03-09 20:22:12 PST
Comment on attachment 50287 [details] proposed patch I might miss my morning coffee... or people from shelbyville has put stuff into the water... > + [GTK] GTK_WIDGET_IS_SENSITIVE deprecated in GTK+ 2.20 please put a verb like "is" there to make it a sentence. :) > + > +#if GTK_CHECK_VERSION(2, 18, 0) > if (GTK_WIDGET_IS_SENSITIVE(widget)) { > +#else > + if (GTK_WIDGET_IS_SENSITIVE(widget)) { > +#endif this looks identical. I think you want to make one of them gtk_widget_is_sensitive?
Philippe Normand
Comment 3 2010-03-10 00:10:31 PST
Created attachment 50372 [details] updated patch
Philippe Normand
Comment 4 2010-03-10 00:11:25 PST
Created attachment 50373 [details] updated patch
WebKit Review Bot
Comment 5 2010-03-10 00:13:27 PST
Attachment 50372 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/579005
Philippe Normand
Comment 6 2010-03-15 01:36:08 PDT
Landed in r55989.
Note You need to log in before you can comment on or make changes to this bug.