Summary: | Eliminate m_mightDownloadFromHandle | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | Page Loading | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Trivial | CC: | darin, ddkilzer | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2010-03-08 14:25:35 PST
Created attachment 50250 [details]
proposed patch
Comment on attachment 50250 [details]
proposed patch
r=me assuming there is no measurable performance penalty to the extra level of indirection of every delegate call
Comment on attachment 50250 [details] proposed patch > + d->m_proxy = wkCreateNSURLConnectionDelegateProxy(); Is ownership correct here? The function has create in its name, but I don't see an adopt. > Is ownership correct here?
I think so - there is an explicit release call below. But I'll change to adopt, to avoid current and future confusion.
d->m_proxy = wkCreateNSURLConnectionDelegateProxy();
[d->m_proxy.get() setDelegate:ResourceHandle::delegate()];
[d->m_proxy.get() release];
Committed <http://trac.webkit.org/changeset/55688>. |