Bug 35868

Summary: [GStreamer] player code cleanups
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch gustavo: review+, gustavo: commit-queue-

Philippe Normand
Reported 2010-03-08 08:07:10 PST
The GOwnPtrGtk.h file should be moved to gstreamer/. The SoupURI stuff inside is no longer needed either. I think we should also use "standard" types for the private variables of the player, like float instead of gfloat, wherever possible
Attachments
proposed patch (12.43 KB, patch)
2010-03-08 09:06 PST, Philippe Normand 		gustavo: review+
gustavo: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-03-08 09:06:57 PST
Created attachment 50228 [details] proposed patch
Gustavo Noronha (kov)
Comment 2 2010-03-08 13:37:07 PST
Comment on attachment 50228 [details] proposed patch I like it, but if you can land the GOwnPtr changes separate from the member variables ones, I'd be happy.
Philippe Normand
Comment 3 2010-03-09 01:03:20 PST
Landed in r55716 and r55717
Note You need to log in before you can comment on or make changes to this bug.