Bug 35868 - [GStreamer] player code cleanups
Summary: [GStreamer] player code cleanups
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-03-08 08:07 PST by Philippe Normand
Modified: 2010-03-09 01:03 PST (History)
0 users

See Also:

proposed patch (12.43 KB, patch)
2010-03-08 09:06 PST, Philippe Normand
gustavo: review+
gustavo: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-03-08 08:07:10 PST
The GOwnPtrGtk.h file should be moved to gstreamer/. The SoupURI stuff inside is no longer needed either.
I think we should also use "standard" types for the private variables of the player, like float instead of gfloat, wherever possible
Comment 1 Philippe Normand 2010-03-08 09:06:57 PST
Created attachment 50228 [details]
proposed patch
Comment 2 Gustavo Noronha (kov) 2010-03-08 13:37:07 PST
Comment on attachment 50228 [details]
proposed patch

I like it, but if you can land the GOwnPtr changes separate from the member variables ones, I'd be happy.
Comment 3 Philippe Normand 2010-03-09 01:03:20 PST
Landed in r55716 and r55717