Summary: | [chromium]: update Linux layout test scripts for RedHat like systems. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Langley <agl> | ||||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dpranke, evan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Adam Langley
2010-03-08 07:56:18 PST
Created attachment 50221 [details]
patch
+ if self._is_redhat_based(): + package_name = 'dwdiff' + else: + package_name = 'wdiff' + + _log.error(' Please install using: "sudo apt-get install ' + + package_name) Does apt-get work on Redhat? I kinda wonder if the dwdiff/wdiff distinction could be factored into one place instead of tested twice. I'm trying to think of a WebKit reviewer who uses Redhat but the GTK guys use Debian I think. Created attachment 50225 [details]
patch
Evan: you're right. We don't try to have distro specific messages for the other cases so I won't try to here. Linux people can figure it out and I don't think it's worth trying to reflect all that complexity in our scripts for these minor cases.
That wasn't a review to death :) But, in hindsight, trying to maintain the 'apt-get' vs 'yum' messages for everyone and their distro specific package names is just going to rot. I still need the other changes or I can't run layout tests! dpranke has been unresponsive for a week and a half now (there was a previous Chromium CL which did the same thing.) Since moving the layout test running in WebKit has completly broken layout tests on all Fedora systems I'll probably land this as an unreviewed build fix later today. Comment on attachment 50225 [details]
patch
LGTM.
Hi Adam, Sorry for the delay. Somehow I completely missed this bug, although I've been pretty busy fixing other bugs in this stuff for the past three days. Comment on attachment 50225 [details]
patch
rs=me.
Comment on attachment 50225 [details] patch Clearing flags on attachment: 50225 Committed r55903: <http://trac.webkit.org/changeset/55903> All reviewed patches have been landed. Closing bug. |