| Summary: | [GStreamer] soften dependency on libsoup in the http src element | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
| Component: | WebKitGTK | Assignee: | Philippe Normand <pnormand> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric, gustavo | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Philippe Normand
2010-03-08 07:00:30 PST
Created attachment 50218 [details]
proposed patch
Comment on attachment 50218 [details]
proposed patch
Looks sane to me, but priv->paused may no longer be true, depending on the network implementation. May warrant a comment?
(In reply to comment #2) > (From update of attachment 50218 [details]) > Looks sane to me, but priv->paused may no longer be true, depending on the > network implementation. May warrant a comment? Why? It will still be assigned to true in webKitWebSrcEnoughDataMainCb. Not sure to understand what comment I should add ;) (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 50218 [details] [details]) > > Looks sane to me, but priv->paused may no longer be true, depending on the > > network implementation. May warrant a comment? > > Why? It will still be assigned to true in webKitWebSrcEnoughDataMainCb. Not > sure to understand what comment I should add ;) Sorry, I meant that it will be telling lies, since the http download has not been truly paused. Attachment 50218 [details] was posted by a committer and has review+, assigning to Philippe Normand for commit.
|