Bug 35859

Summary: [DRT/Chromium] Add EventSendingController
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, fishd, hamaji, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Bug Depends on:    
Bug Blocks: 35902    
Attachments:
Description Flags
Proposed patch
none
Proposed patch rev.2 (style fix)
none
Proposed patch rev.3 (style fix) dglazkov: review+

Kent Tamura
Reported 2010-03-08 03:03:52 PST
[DRT/Chromium] Add EventSendingController
Attachments
Proposed patch (36.73 KB, patch)
2010-03-08 03:05 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Proposed patch rev.2 (style fix) (36.73 KB, patch)
2010-03-08 03:11 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Proposed patch rev.3 (style fix) (36.74 KB, patch)
2010-03-08 04:21 PST, Kent Tamura 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2010-03-08 03:05:41 PST
Created attachment 50200 [details] Proposed patch
WebKit Review Bot
Comment 2 2010-03-08 03:10:34 PST
Attachment 50200 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/DumpRenderTree/chromium/EventSendingController.cpp:782: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebKitTools/DumpRenderTree/chromium/EventSendingController.cpp:784: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kent Tamura
Comment 3 2010-03-08 03:11:57 PST
Created attachment 50202 [details] Proposed patch rev.2 (style fix)
Kent Tamura
Comment 4 2010-03-08 03:12:34 PST
Some notes for the patch: - I left ScopedRunnableMethodFactory. It's defined in task.h and task.h is needed for MessageLoop::current()->postTask(). - gfx::Point was replaced with WebKit::WebPoint.
WebKit Review Bot
Comment 5 2010-03-08 03:16:50 PST
Attachment 50202 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/DumpRenderTree/chromium/EventSendingController.cpp:782: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebKitTools/DumpRenderTree/chromium/EventSendingController.cpp:784: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kent Tamura
Comment 6 2010-03-08 04:21:21 PST
Created attachment 50206 [details] Proposed patch rev.3 (style fix)
Dimitri Glazkov (Google)
Comment 7 2010-03-08 20:51:15 PST
Comment on attachment 50206 [details] Proposed patch rev.3 (style fix) ok, except let's rename the file to EventSender.h/cpp
Kent Tamura
Comment 8 2010-03-08 22:49:37 PST
(In reply to comment #7) > (From update of attachment 50206 [details]) > ok, except let's rename the file to EventSender.h/cpp Ok, I renamed files, the class name, updated ChangeLog, did check-webkit-style.
Kent Tamura
Comment 9 2010-03-08 22:52:44 PST
Landed as r55713.
Note You need to log in before you can comment on or make changes to this bug.