Summary: | [DRT/Chromium] Add EventSendingController | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, fishd, hamaji, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 35902 | ||||||||||
Attachments: |
|
Description
Kent Tamura
2010-03-08 03:03:52 PST
Created attachment 50200 [details]
Proposed patch
Attachment 50200 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/DumpRenderTree/chromium/EventSendingController.cpp:782: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
WebKitTools/DumpRenderTree/chromium/EventSendingController.cpp:784: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 50202 [details]
Proposed patch rev.2 (style fix)
Some notes for the patch: - I left ScopedRunnableMethodFactory. It's defined in task.h and task.h is needed for MessageLoop::current()->postTask(). - gfx::Point was replaced with WebKit::WebPoint. Attachment 50202 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/DumpRenderTree/chromium/EventSendingController.cpp:782: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
WebKitTools/DumpRenderTree/chromium/EventSendingController.cpp:784: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 50206 [details]
Proposed patch rev.3 (style fix)
Comment on attachment 50206 [details]
Proposed patch rev.3 (style fix)
ok, except let's rename the file to EventSender.h/cpp
(In reply to comment #7) > (From update of attachment 50206 [details]) > ok, except let's rename the file to EventSender.h/cpp Ok, I renamed files, the class name, updated ChangeLog, did check-webkit-style. |