Bug 35852

Summary:

[DRT/Chromium] Add PlainTextController and TextInputController

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

Tools / Tests

Assignee:

Kent Tamura <tkent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, fishd, hamaji

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

All

Bug Depends on:

Bug Blocks:

35902

Attachments:

Description	Flags
Proposed patch	dglazkov: review+

Kent Tamura

Reported 2010-03-07 21:41:21 PST

[DRT/Chromium] Add PlainTextController and TextInputController

Attachments
Proposed patch (17.45 KB, patch) 2010-03-07 21:44 PST, Kent Tamura	dglazkov: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kent Tamura

Comment 1 2010-03-07 21:44:48 PST

Created attachment 50188 [details] Proposed patch

Kent Tamura

Comment 2 2010-03-07 21:51:39 PST

Note: - NOTIMPELMENTED() macros in the original code was replaced with notImplemented(). notImplemented() is not one in WebCore/platform/NotImplemented.h, and is defined as empty in config.h for now.

Dimitri Glazkov (Google)

Comment 3 2010-03-08 09:16:08 PST

I think we can just remove notImplemented and replace it with a FIXME: Implement this -- this is what other ports are doing.

Dimitri Glazkov (Google)

Comment 4 2010-03-08 20:52:48 PST

Comment on attachment 50188 [details] Proposed patch ok, except replace notImplemented with FIXMEs.

Kent Tamura

Comment 5 2010-03-08 22:39:48 PST

Committed r55712: <http://trac.webkit.org/changeset/55712>

Kent Tamura

Comment 6 2010-03-08 22:40:44 PST

(In reply to comment #4) > (From update of attachment 50188 [details]) > ok, except replace notImplemented with FIXMEs. I replaced notImplemented() with FIXME, and landed.

Note You need to log in before you can comment on or make changes to this bug.