Bug 35845

Summary: webkitpy/init/logtesting.py: Refactor the code for unit-testing logging
Product: WebKit Reporter: Chris Jerdonek <cjerdonek>
Component: Tools / TestsAssignee: Chris Jerdonek <cjerdonek>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, eric, hamaji, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
cjerdonek: commit-queue-
Proposed patch 2 hamaji: review+, cjerdonek: commit-queue-

Chris Jerdonek
Reported 2010-03-07 13:07:02 PST
The code for unit-testing logging can be simplified and cleaned up somewhat. It can also be documented more.
Attachments
Proposed patch (18.24 KB, patch)
2010-03-07 13:47 PST, Chris Jerdonek 		cjerdonek: commit-queue-
DetailsFormatted DiffDiff
Proposed patch 2 (17.38 KB, patch)
2010-03-10 05:00 PST, Chris Jerdonek 		hamaji: review+
cjerdonek: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-03-07 13:47:06 PST
Created attachment 50176 [details] Proposed patch This patch needs to be landed after committing the version-checking patch: https://bugs.webkit.org/show_bug.cgi?id=35788 So the style bot might not work.
Chris Jerdonek
Comment 2 2010-03-10 05:00:58 PST
Created attachment 50393 [details] Proposed patch 2 Revised the patch so it does not depend on another patch being committed. (The style bot should also work on it now, as a result.)
Shinichiro Hamaji
Comment 3 2010-03-10 06:38:18 PST
Comment on attachment 50393 [details] Proposed patch 2 Looks good.
Chris Jerdonek
Comment 4 2010-03-10 10:33:24 PST
Manually committed: http://trac.webkit.org/changeset/55786
Note You need to log in before you can comment on or make changes to this bug.