Bug 35840 – Update QtWebKit library name under Windows in webkitdir.pm so that run-launcher can work.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Daniel Bates]

We should update the library name in webkitdir.pm to match the change made in changeset 53924 <http://trac.webkit.org/changeset/53924> so that run-launcher can find the built QtWebKit library and launch the QtLauncher application.

[Daniel Bates]

Created attachment 50226 [details]
Patch

[Jocelyn Turcotte]

> We should update the library name in webkitdir.pm to match the change made in
> changeset 53924 <http://trac.webkit.org/changeset/53924> so that run-launcher
> can find the built QtWebKit library and launch the QtLauncher application.

Agreed, the 'd' suffix is only in debug so you might want to add something like
if configuration() eq "Debug"(In reply to comment #0)

[Daniel Bates]

Comment on attachment 50226 [details]
Patch

Will update patch

[Daniel Bates]

Created attachment 50371 [details]
Patch

Updated patch to only add the "d" suffix if its a debug Windows build.

[Tor Arne Vestbø]

Please follow the QtWebKit bug reporting guidelines when reporting bugs.

See http://trac.webkit.org/wiki/QtWebKitBugs

Specifically:

  - The 'QtWebKit' component should only be used for bugs/features in the
    public QtWebKit API layer, not to signify that the bug is specific to
    the Qt port of WebKit

      http://trac.webkit.org/wiki/QtWebKitBugs#Component

  - Add the keyword 'Qt' to signal that it's a Qt-related bug

      http://trac.webkit.org/wiki/QtWebKitBugs#Keywords

[Daniel Bates]

Comment on attachment 50371 [details]
Patch

Clearing flags on attachment: 50371

Committed r55829: <http://trac.webkit.org/changeset/55829>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.