Bug 35835

Summary:

test-webkitpy: Adjust logging code so that "side-effect" messages do not render to the screen

Product:

WebKit

Reporter:

Chris Jerdonek <cjerdonek>

Component:

Tools / Tests

Assignee:

Chris Jerdonek <cjerdonek>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cjerdonek, eric, hamaji, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	abarth: review+, cjerdonek: commit-queue-

Description Chris Jerdonek 2010-03-06 16:42:30 PST

Currently, if we configure logging in test-webkitpy, then spurious log messages will get logged to the screen as a side effect of the code that the unit tests are executing.  We should suppress those spurious log messages.

The solution here will involve something like setting the "propagate" attribute on any test loggers to False so that the log messages will not propagate up to the root logger and be logged.

Comment 1 Chris Jerdonek 2010-03-07 08:39:00 PST

Created attachment 50173 [details]
Proposed patch

Comment 2 Adam Barth 2010-03-13 02:18:59 PST

Comment on attachment 50173 [details]
Proposed patch

Python's logging is much more awesome than what Eric cooked up on his own.  Thanks for educating us in the ways of Python.

Comment 3 Chris Jerdonek 2010-03-13 15:50:36 PST

Manually committed (via git svn dcommit):

http://trac.webkit.org/changeset/55971