Bug 35829

Summary: Web Inspector: switching to/from Timeline Panel moves scrolled region.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, loislo, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed fix. jorlow: review+

Pavel Feldman
Reported 2010-03-06 09:36:33 PST
The reason is that when switching back, sidebar tree is the default focus target, but has random scroll offset. The only solution i've found is to 1) prevent scroller from being default focus target 2) manually restore scroll offset upon show. Only (1) or only (2) does not work for the reason above.
Attachments
[PATCH] Proposed fix. (5.59 KB, patch)
2010-03-06 09:39 PST, Pavel Feldman 		jorlow: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-03-06 09:39:39 PST
Created attachment 50153 [details] [PATCH] Proposed fix.
Pavel Feldman
Comment 2 2010-03-06 10:02:34 PST
I'd like to land this soon for the nightly / dev channel. So I am asking for formal reviewer from somebody. I'll make sure this is fine with Tim (xenon) who was reviewing my timeline code. This change was tested well and is safe. Brings only good :)
Jeremy Orlow
Comment 3 2010-03-06 10:02:37 PST
Comment on attachment 50153 [details] [PATCH] Proposed fix. Seems reasonable. r=me
Pavel Feldman
Comment 4 2010-03-06 10:15:09 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/front-end/TimelinePanel.js Committed r55627
Timothy Hatcher
Comment 5 2010-03-06 11:51:23 PST
Looks fine.
Note You need to log in before you can comment on or make changes to this bug.