Summary: | python: Remove non-trivial code from webkitpy/__init__.py | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Jerdonek <cjerdonek> | ||||
Component: | Tools / Tests | Assignee: | Chris Jerdonek <cjerdonek> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, cjerdonek, eric, hamaji, levin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 31533 | ||||||
Attachments: |
|
Description
Chris Jerdonek
2010-03-06 05:03:48 PST
Created attachment 50151 [details]
Proposed patch
Comment on attachment 50151 [details]
Proposed patch
Ok. I'm slightly sad that we don't say "mechanize" anywhere when we import Browser. Is there some way to say:
from webkitpy.thirdparty.autoinstalled.mechanize import Browser
That seems the most natural to me.
(In any case, this patch is an improvement.)
(In reply to comment #2) > (From update of attachment 50151 [details]) > Ok. I'm slightly sad that we don't say "mechanize" anywhere when we import > Browser. Yeah, I agree. > Is there some way to say: > > from webkitpy.thirdparty.autoinstalled.mechanize import Browser I tried this and couldn't seem to get it to work -- probably because mechanize.py doesn't actually exist in thirdparty/autoinstalled. The closest I could come was this: > import webkitpy.thirdparty.autoinstalled.mechanize as mechanize > Browser = mechanize.Browser But that takes two lines in each calling file which seems less preferable. In any case, the good news is that this is a temporary measure. It will go away once I re-submit the autoinstall rewrite. I'll be doing that once I land all this version-checking stuff. Manually committed (via git svn dcommit): http://trac.webkit.org/changeset/55969 |