| Summary: | Animation fill mode breaks windows tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | Evangelism | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | simon.fraser, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | 26869 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2010-03-05 15:11:25 PST
Created attachment 50137 [details]
windows patch and test updates
Attachment 50137 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/animation/Animation.h:101: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 50137 [details] windows patch and test updates > diff --git a/WebCore/platform/animation/Animation.h b/WebCore/platform/animation/Animation.h > - AnimationFillMode m_fillMode : 2; > + unsigned m_fillMode : 3; I'm pretty sure you only need 2 bits here. r=me changed :3 to :2 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/animations/fill-mode-transform-expected.txt M LayoutTests/animations/fill-mode-transform.html M LayoutTests/platform/mac-leopard/Skipped M LayoutTests/platform/mac-snowleopard/Skipped M WebCore/ChangeLog M WebCore/css/CSSComputedStyleDeclaration.cpp M WebCore/css/CSSStyleSelector.cpp M WebCore/platform/animation/Animation.h M WebCore/platform/graphics/mac/GraphicsLayerCA.mm M WebCore/rendering/style/RenderStyleConstants.h Committed r55601 |