Bug 35815 – Animation fill mode breaks windows tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Evangelism

[Dean Jackson]

The bitfield for fill mode is too small. Make it unsigned, larger, and move the enum to RenderStyleConstants.h.

[Dean Jackson]

Created attachment 50137 [details]
windows patch and test updates

[WebKit Review Bot]

Attachment 50137 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/animation/Animation.h:101:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 50137 [details]
windows patch and test updates

> diff --git a/WebCore/platform/animation/Animation.h b/WebCore/platform/animation/Animation.h

> -    AnimationFillMode m_fillMode : 2;
> +    unsigned m_fillMode : 3;

I'm pretty sure you only need 2 bits here.

r=me

[Dean Jackson]

changed :3 to :2

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/animations/fill-mode-transform-expected.txt
	M	LayoutTests/animations/fill-mode-transform.html
	M	LayoutTests/platform/mac-leopard/Skipped
	M	LayoutTests/platform/mac-snowleopard/Skipped
	M	WebCore/ChangeLog
	M	WebCore/css/CSSComputedStyleDeclaration.cpp
	M	WebCore/css/CSSStyleSelector.cpp
	M	WebCore/platform/animation/Animation.h
	M	WebCore/platform/graphics/mac/GraphicsLayerCA.mm
	M	WebCore/rendering/style/RenderStyleConstants.h
Committed r55601