Bug 35800

Summary:

Notification object should expose absolute URL of icon

Product:

WebKit

Reporter:

John Gregg <johnnyg>

Component:

WebCore Misc.

Assignee:

John Gregg <johnnyg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	fishd: review-, johnnyg: commit-queue-
new patch which leaves old interface temporarily	none

Description John Gregg 2010-03-05 11:32:36 PST

Currently the Notification object only exposes the raw string that was supplied for the icon parameter in javascript, which prevents relative URLs from working.

Furthermore the Chromium WebKit API exposes icon as a WebString, but it really should be a WebURL.

Comment 1 John Gregg 2010-03-05 11:58:52 PST

Created attachment 50108 [details]
patch

Comment 2 Darin Fisher (:fishd, Google) 2010-03-05 14:37:38 PST

Comment on attachment 50108 [details]
patch

Please preserve the old Chromium WebKit APIs temporarily to avoid requiring a 2-sided patch landing?  Add a comment to the old method with the text "DEPRECATED", then after the Chromium side switches over to the new API, do another WebKit patch to remove the deprecated method.

Comment 3 John Gregg 2010-03-08 09:51:22 PST

Created attachment 50230 [details]
new patch which leaves old interface temporarily

new patch which leaves old interface temporarily

Comment 4 WebKit Commit Bot 2010-03-15 23:42:36 PDT

Comment on attachment 50230 [details]
new patch which leaves old interface temporarily

Clearing flags on attachment: 50230

Committed r56043: <http://trac.webkit.org/changeset/56043>

Comment 5 WebKit Commit Bot 2010-03-15 23:42:40 PDT

All reviewed patches have been landed.  Closing bug.