Bug 35800 - Notification object should expose absolute URL of icon
Summary: Notification object should expose absolute URL of icon
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: John Gregg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-05 11:32 PST by John Gregg
Modified: 2010-03-15 23:42 PDT (History)
1 user (show)

See Also:

Attachments
patch (3.67 KB, patch)
2010-03-05 11:58 PST, John Gregg 		fishd: review-
johnnyg: commit-queue-
Details | Formatted Diff | Diff
new patch which leaves old interface temporarily (3.85 KB, patch)
2010-03-08 09:51 PST, John Gregg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Gregg 2010-03-05 11:32:36 PST 
Currently the Notification object only exposes the raw string that was supplied for the icon parameter in javascript, which prevents relative URLs from working.

Furthermore the Chromium WebKit API exposes icon as a WebString, but it really should be a WebURL.
Comment 1 John Gregg 2010-03-05 11:58:52 PST 
Created attachment 50108 [details]
patch
Comment 2 Darin Fisher (:fishd, Google) 2010-03-05 14:37:38 PST 
Comment on attachment 50108 [details]
patch

Please preserve the old Chromium WebKit APIs temporarily to avoid requiring a 2-sided patch landing?  Add a comment to the old method with the text "DEPRECATED", then after the Chromium side switches over to the new API, do another WebKit patch to remove the deprecated method.
Comment 3 John Gregg 2010-03-08 09:51:22 PST 
Created attachment 50230 [details]
new patch which leaves old interface temporarily

new patch which leaves old interface temporarily
Comment 4 WebKit Commit Bot 2010-03-15 23:42:36 PDT 
Comment on attachment 50230 [details]
new patch which leaves old interface temporarily

Clearing flags on attachment: 50230

Committed r56043: <http://trac.webkit.org/changeset/56043>
Comment 5 WebKit Commit Bot 2010-03-15 23:42:40 PDT 
All reviewed patches have been landed.  Closing bug.