RESOLVED FIXED Bug 35800
Notification object should expose absolute URL of icon 
https://bugs.webkit.org/show_bug.cgi?id=35800
Summary Notification object should expose absolute URL of icon
John Gregg
Reported 2010-03-05 11:32:36 PST
Currently the Notification object only exposes the raw string that was supplied for the icon parameter in javascript, which prevents relative URLs from working. Furthermore the Chromium WebKit API exposes icon as a WebString, but it really should be a WebURL.
Attachments
patch (3.67 KB, patch)
2010-03-05 11:58 PST, John Gregg 		fishd: review-
johnnyg: commit-queue-
DetailsFormatted DiffDiff
new patch which leaves old interface temporarily (3.85 KB, patch)
2010-03-08 09:51 PST, John Gregg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
John Gregg
Comment 1 2010-03-05 11:58:52 PST
Created attachment 50108 [details] patch
Darin Fisher (:fishd, Google)
Comment 2 2010-03-05 14:37:38 PST
Comment on attachment 50108 [details] patch Please preserve the old Chromium WebKit APIs temporarily to avoid requiring a 2-sided patch landing? Add a comment to the old method with the text "DEPRECATED", then after the Chromium side switches over to the new API, do another WebKit patch to remove the deprecated method.
John Gregg
Comment 3 2010-03-08 09:51:22 PST
Created attachment 50230 [details] new patch which leaves old interface temporarily new patch which leaves old interface temporarily
WebKit Commit Bot
Comment 4 2010-03-15 23:42:36 PDT
Comment on attachment 50230 [details] new patch which leaves old interface temporarily Clearing flags on attachment: 50230 Committed r56043: <http://trac.webkit.org/changeset/56043>
WebKit Commit Bot
Comment 5 2010-03-15 23:42:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.