Summary: | [Qt] QtLauncher need a menu option to show/hide FPS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jesus Sanchez-Palencia <jesus> | ||||||
Component: | New Bugs | Assignee: | QtWebKit Unassigned <webkit-qt-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Enhancement | CC: | commit-queue, jturcotte | ||||||
Priority: | P2 | Keywords: | Qt | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Jesus Sanchez-Palencia
2010-03-05 09:56:28 PST
Created attachment 50101 [details]
Patch
Comment on attachment 50101 [details]
Patch
This patch does not apply, thus it can't be commit-queue'd.
Since when do browsers have an fps? :)
Comment on attachment 50101 [details]
Patch
Apart from the commit queue problem the patch looks good to me (I've been looking for this option, too :)
I think in general it would be good to replace all the commandline options of QtLauncher with menus actions.
(In reply to comment #3) There was a problem with the patches order, I guess. I'll fix this as soon as I'm back from Bossa conference (in 4 days). thanks for the review! Please follow the QtWebKit bug reporting guidelines when reporting bugs. See http://trac.webkit.org/wiki/QtWebKitBugs Specifically: - The 'QtWebKit' component should only be used for bugs/features in the public QtWebKit API layer, not to signify that the bug is specific to the Qt port of WebKit http://trac.webkit.org/wiki/QtWebKitBugs#Component - Add the keyword 'Qt' to signal that it's a Qt-related bug http://trac.webkit.org/wiki/QtWebKitBugs#Keywords Created attachment 50622 [details]
Add Show FPS option to QtLauncher
Fixed.
Comment on attachment 50622 [details] Add Show FPS option to QtLauncher Clearing flags on attachment: 50622 Committed r55956: <http://trac.webkit.org/changeset/55956> All reviewed patches have been landed. Closing bug. |