Bug 35774

Summary: [DRT/Chromium] Add AccessibilityController.{cpp,h} and AccessibilityUIElement.{cpp,h}
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, fishd, hamaji, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 35902    
Attachments:
Description Flags
Proposed patch
none
Proposed patch rev.2 (style fixes) dglazkov: review+

Description Kent Tamura 2010-03-04 17:22:30 PST
[DRT/Chromium] Add AccessibilityController.{cpp,h} and AccessibilityUIElement.{cpp,h}
Comment 1 Kent Tamura 2010-03-04 17:28:51 PST
Created attachment 50069 [details]
Proposed patch
Comment 2 WebKit Review Bot 2010-03-04 17:30:07 PST
Attachment 50069 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:260:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:481:  One line control clauses should not use braces.  [whitespace/braces] [4]
WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:515:  One space before end of line comments  [whitespace/comments] [5]
WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:522:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:559:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:563:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
WebKitTools/DumpRenderTree/chromium/AccessibilityController.cpp:44:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
WebKitTools/DumpRenderTree/chromium/AccessibilityController.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 8 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kent Tamura 2010-03-04 17:36:55 PST
Created attachment 50071 [details]
Proposed patch rev.2 (style fixes)
Comment 4 Dimitri Glazkov (Google) 2010-03-07 18:47:07 PST
Comment on attachment 50071 [details]
Proposed patch rev.2 (style fixes)

ok.
Comment 5 Kent Tamura 2010-03-07 20:25:04 PST
Thanks.  I'll remove TODO(name) comments before landing.
Comment 6 Kent Tamura 2010-03-07 21:03:15 PST
Landed as r55655.