| Summary: | [DRT/Chromium] Add AccessibilityController.{cpp,h} and AccessibilityUIElement.{cpp,h} | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dglazkov, fishd, hamaji, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 35902 | ||||||||
| Attachments: |
|
||||||||
Created attachment 50069 [details]
Proposed patch
Attachment 50069 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:260: Place brace on its own line for function definitions. [whitespace/braces] [4]
WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:481: One line control clauses should not use braces. [whitespace/braces] [4]
WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:515: One space before end of line comments [whitespace/comments] [5]
WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:522: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:559: Place brace on its own line for function definitions. [whitespace/braces] [4]
WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:563: Place brace on its own line for function definitions. [whitespace/braces] [4]
WebKitTools/DumpRenderTree/chromium/AccessibilityController.cpp:44: Place brace on its own line for function definitions. [whitespace/braces] [4]
WebKitTools/DumpRenderTree/chromium/AccessibilityController.h:35: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 8 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 50071 [details]
Proposed patch rev.2 (style fixes)
Comment on attachment 50071 [details]
Proposed patch rev.2 (style fixes)
ok.
Thanks. I'll remove TODO(name) comments before landing. |
[DRT/Chromium] Add AccessibilityController.{cpp,h} and AccessibilityUIElement.{cpp,h}