Summary: | New port: EFL; adding files to WebCore/plugins/efl (patch 1/2) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Leandro Pereira <leandro> | ||||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED WONTFIX | ||||||||||
Severity: | Enhancement | CC: | barbieri, bunhere, commit-queue, eric, gustavo, gyuyoung.kim, kenneth, oliver, rakuco, tonikitoo, webkit.review.bot, zimmermann | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Leandro Pereira
2010-03-04 12:02:03 PST
Created attachment 50044 [details]
Add files to WebCore/plugins/efl (patch 1/2)
Attachment 50044 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/plugins/efl/PluginViewEfl.cpp:39: Alphabetical sorting problem. [build/include_order] [4]
WebCore/plugins/efl/PluginViewEfl.cpp:44: Alphabetical sorting problem. [build/include_order] [4]
WebCore/plugins/efl/PluginViewEfl.cpp:53: Alphabetical sorting problem. [build/include_order] [4]
WebCore/plugins/efl/PluginViewEfl.cpp:62: Alphabetical sorting problem. [build/include_order] [4]
WebCore/plugins/efl/PluginPackageEfl.cpp:38: Alphabetical sorting problem. [build/include_order] [4]
WebCore/plugins/efl/PluginPackageEfl.cpp:42: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 6 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 50047 [details]
Add files to WebCore/plugins/efl (patch 1/2)
Add revised patch, so it passes style-queue requirements.
Comment on attachment 50047 [details]
Add files to WebCore/plugins/efl (patch 1/2)
Upstream PLuginView code has changed, you should implement getPlatformValue and only for the attributes not handled in the common PluginView::getValue impl.
Created attachment 50409 [details]
Add files to WebCore/plugins/efl (patch 1/2)
Updated patch.
Please close this bug as we'll go with Plugin*None as requested by Zecke as soon as #37478 is done. Closing this bug as we'll use the Plugin*None implementation until we have a better Plugin implementation. Comment on attachment 50409 [details]
Add files to WebCore/plugins/efl (patch 1/2)
Clearing flags.
|