Bug 35749

Summary:

New port: EFL; adding files to WebCore/platform/efl

Product:

WebKit

Reporter:

Leandro Pereira <leandro>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Enhancement

CC:

barbieri, bunhere, commit-queue, eric, gustavo, gyuyoung.kim, kenneth, oliver, rakuco, tonikitoo, webkit.review.bot, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
Add files to WebCore/platform/efl.	none

Leandro Pereira

Reported 2010-03-04 10:44:51 PST

+++ This bug was initially created as a clone of Bug #35087 +++ Subject says it all.

Attachments
Add files to WebCore/platform/efl. (24.90 KB, patch) 2010-03-04 10:45 PST, Leandro Pereira	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Leandro Pereira

Comment 1 2010-03-04 10:45:31 PST

Created attachment 50034 [details] Add files to WebCore/platform/efl.

Eric Seidel (no email)

Comment 2 2010-03-04 14:01:53 PST

Comment on attachment 50034 [details] Add files to WebCore/platform/efl. Please create paches with our tools (svn-create-patch or webkit-patch) so that they end up with the ChangeLog first in the diff. :) Also this would be clearer to me as an even smaller diff.

Leandro Pereira

Comment 3 2010-03-05 06:56:56 PST

(In reply to comment #2) > > Also this would be clearer to me as an even smaller diff. > How small? May I just attach the chunks here or create a bug report for each?

Eric Seidel (no email)

Comment 4 2010-03-05 13:14:16 PST

These are pretty much all logically distinct implementations. They're easier to rubber-stamp one functional area at a time. In the case of patches like this, although I may feel that your system time implementation is fine, I might have questions about the clipboard implementation. Tying them together, just delays reviews. :(

Leandro Pereira

Comment 5 2010-03-08 10:10:11 PST

(In reply to comment #4) > These are pretty much all logically distinct implementations. They're easier > to rubber-stamp one functional area at a time. In the case of patches like > this, although I may feel that your system time implementation is fine, I might > have questions about the clipboard implementation. Tying them together, just > delays reviews. :( OK. I'll clone this bug for each .cpp/.h pair. This should speed up the review process.

Leandro Pereira

Comment 6 2010-03-08 15:33:45 PST

I'm closing this bug since the patch included here was splitted into several other bug reports.

Note You need to log in before you can comment on or make changes to this bug.